Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorchjob doesn't have status.startTIme. #1566

Closed
aheeruru opened this issue Mar 30, 2022 · 1 comment · Fixed by #1567
Closed

pytorchjob doesn't have status.startTIme. #1566

aheeruru opened this issue Mar 30, 2022 · 1 comment · Fixed by #1567

Comments

@aheeruru
Copy link

Hi,
pytorchjob doesn't provide status.startTime.
mpi and tfjob has function to update status.startTime, but pytorchjob doesn't have.
Is it deprecated? Or just missing?

if jobStatus.StartTime == nil {
		now := metav1.Now()
		jobStatus.StartTime = &now
		// enqueue a sync to check if job past ActiveDeadlineSeconds
		if tfJob.Spec.RunPolicy.ActiveDeadlineSeconds != nil {
			logger.Infof("Job with ActiveDeadlineSeconds will sync after %d seconds", *tfJob.Spec.RunPolicy.ActiveDeadlineSeconds)
			// TODO(Jeffwan): requeue job key in reconciler scenarios
			r.WorkQueue.AddAfter(tfJobKey, time.Duration(*tfJob.Spec.RunPolicy.ActiveDeadlineSeconds)*time.Second)
		}
	}
@cheimu
Copy link
Member

cheimu commented Mar 30, 2022

Hi @aheeruru

Thank you. I think you are right. XGB job also doesn't update startTime. Let me add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants