Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Create unify client for all Training Job types #1691

Closed
andreyvelich opened this issue Nov 17, 2022 · 5 comments · Fixed by #1719
Closed

[SDK] Create unify client for all Training Job types #1691

andreyvelich opened this issue Nov 17, 2022 · 5 comments · Fixed by #1719

Comments

@andreyvelich
Copy link
Member

Recently we introduced SDKs for MPIJob: #1608 and XGBoostJob: #1607 in a separate Kubernetes Python clients.

All of our clients (TFJobClient, PyTorchJobClient, MPIJobClient, XGBoostJobClient, MXJobClient) use logically the same CRUD APIs and we can reduce our code base.
Also, from the user perspective I don't think it is neseccary to create various Kubernetes Python clients for each training framework (e.g. TF, PyTorch, etc.)

I propose to create the unify TrainingClient (similar to our unify Training Controller) and to define APIs for each job under this class. For example, create_tfjob, create_pytorchjob, create_mxjob_from_func, etc.
I think that will simplify our UX and SDK maintenance effort.

/kind discussion
@kubeflow/wg-training-leads @tenzen-y @anencore94 What do you think ?

@andreyvelich
Copy link
Member Author

/area sdk

@terrytangyuan
Copy link
Member

Great idea!

@johnugeorge
Copy link
Member

Agree. It will give a better user experience

@tenzen-y
Copy link
Member

Looks great!

@andreyvelich
Copy link
Member Author

/assign @andreyvelich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants