Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: some comments about API changes from PR #215 review #249

Closed
ScorpioCPH opened this issue Dec 27, 2017 · 5 comments
Closed

API: some comments about API changes from PR #215 review #249

ScorpioCPH opened this issue Dec 27, 2017 · 5 comments
Labels
area/api kind/api-change priority/p2
Milestone
Kubecon Europe

Comments

@ScorpioCPH
Copy link
Member

@jlewi Hi, file this issue to track API comments from PR #215:

  • Reuse metadata.UID instead of RuntimeId in TfJobSpec.
  • Maybe we should revisit status representation: State/ReplicaState/TfReplicaStatus.
This was referenced Dec 27, 2017
Closed
Merged
@jlewi
Copy link
Contributor

jlewi commented Dec 27, 2017

What are the properties of UID? i.e. how long is it and what characters does it use?

@ScorpioCPH
Copy link
Member Author

@jlewi Hi, It is defined here, Identifiers and Names in Kubernetes

UID: A non-empty, opaque, system-generated value guaranteed to be unique in time and space; intended to distinguish between historical occurrences of similar entities.

@jlewi
Copy link
Contributor

jlewi commented Dec 29, 2017

Great. I think you are right we can and should replace RuntimeId with the UID; although we might need to truncate it.

@jlewi jlewi added this to the Kubecon Europe milestone Jan 25, 2018
@jlewi jlewi added the area/api label Jan 25, 2018
@jlewi
Copy link
Contributor

jlewi commented Mar 7, 2018

The v1alpha2 API (kubeflow/community#30) gets rid of runtime id.

@jlewi
Copy link
Contributor

jlewi commented Apr 2, 2018

I'm closing this issue because I think its resolved by the v1alpha2 API.

@jlewi jlewi closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api kind/api-change priority/p2
Projects
None yet
Milestone
Kubecon Europe
Development

No branches or pull requests
3 participants
@jlewi @gaocegege @ScorpioCPH