Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tide is misconfigured for this repository. #433

Closed
cjwagner opened this issue Mar 5, 2018 · 1 comment
Closed

Tide is misconfigured for this repository. #433

cjwagner opened this issue Mar 5, 2018 · 1 comment
Assignees
Labels

Comments

@cjwagner
Copy link
Member

cjwagner commented Mar 5, 2018

/assign @jlewi
/kind bug

Based on Prow's logs, Tide is misconfigured for this repository. Specifically, Tide is throwing this error when trying to merge some PRs in this repository.

At least 1 approving review is required by reviewers with write access.

This error is occurring because Tide was not configured to require an approving review as a merge requirement, but the Github repo has been configured to require it. There are a few ways this can be solved:

  1. Remove the requirement from the Github repo.
  2. Add the requirement to the Tide query so that Tide respects the requirement. (Here is an example).
  3. Give @k8s-ci-robot permissions to violate the merge requirement by making it a repo owner and allowing repo owners to bypass merge requirements. (This is probably not a good option).
@jlewi
Copy link
Contributor

jlewi commented Mar 6, 2018

@cjwagner Thank you!

I removed the requirement

Require pull request reviews before merging for the master branch.

Since we require /lgtm and /approve from the prow plugins I don't think there's any need to also require a GitHub approval that seems like toil for reviewers.

See also kubeflow/community#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants