Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presubmit test(bootstrap.py) doesn't properly check out PRs #59

Closed
jlewi opened this issue Oct 18, 2017 · 1 comment
Closed

presubmit test(bootstrap.py) doesn't properly check out PRs #59

jlewi opened this issue Oct 18, 2017 · 1 comment

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 18, 2017

Presubmit test submitted on #36 failed with the following error.

INFO:root:Image info:
{
  "image": "gcr.io/mlkube-testing/builder:v20171017-470b0d6"
}
INFO:root:repo https://github.com/jlewi/mlkube.io.git
INFO:root:Running: git clone https://github.com/jlewi/mlkube.io.git /go/src/github.com/jlewi/mlkube.io
Cloning into '/go/src/github.com/jlewi/mlkube.io'...
INFO:root:Running: git checkout 9a62ee96cabfeb0a10fba304a634771325501e82
fatal: reference is not a tree: 9a62ee96cabfeb0a10fba304a634771325501e82
Traceback (most recent call last):
  File "/workspace/bootstrap.py", line 110, in <module>
    main()
  File "/workspace/bootstrap.py", line 102, in main
    src_dir, sha = clone_repo()
  File "/workspace/bootstrap.py", line 78, in clone_repo
    run(["git", "checkout", sha], cwd=dest)
  File "/workspace/bootstrap.py", line 38, in run
    subprocess.check_call(command, cwd=cwd)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'checkout', '9a62ee96cabfeb0a10fba304a634771325501e82']' returned non-zero exit status 128

Looks like the issue is that bootstrap.py is trying to checkout the code from github.com/jlewi/mlkube.io. But since the PR is from a different user the code is in a different repo.

So to fix it I need to figure out which environment variables to use. We can modify boostrap.py to log the environment variables.

@jlewi
Copy link
Contributor Author

jlewi commented Oct 19, 2017

Fixed by #60

@jlewi jlewi closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant