Notify admin exp certs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to remove circular dependency in tests.
tamalsaha
requested changes
Jul 3, 2017
pkg/cert/cert_watcher_test.go
Outdated
| apiv1 "k8s.io/client-go/pkg/api/v1" | ||
| ) | ||
|
|
||
| func TestIsSoonExpired(t *testing.T) { |
There was a problem hiding this comment.
Each test should be its own method.
pkg/notifier/lib.go
Outdated
| if !ok { | ||
| return nil, errors.New("No notifier set") | ||
| } | ||
| driver := extpoints.Drivers.Lookup(via) |
There was a problem hiding this comment.
Just use a switch statement, simpler
There was a problem hiding this comment.
use switch and simple methods call to notify lib instead of all these ext points and boiler plate.
pkg/cert/cert_watcher.go
Outdated
| return false, int(cert.NotAfter.Sub(time.Now()) / (24 * time.Hour)), nil | ||
| } | ||
|
|
||
| func (c CertWatcher) configuration() (map[string]string, error) { |
There was a problem hiding this comment.
/var/run/secrets/kubernetes.io/serviceaccount/ca.crt
sadlil
suggested changes
Jul 3, 2017
pkg/cert/cert_watcher.go
Outdated
| } | ||
|
|
||
| func (c CertWatcher) Run() { | ||
| f, err := os.Open(c.CertPath) |
There was a problem hiding this comment.
Open file on every tick and close it when the tick finishes.
pkg/notifier/lib.go
Outdated
| if !ok { | ||
| return nil, errors.New("No notifier set") | ||
| } | ||
| driver := extpoints.Drivers.Lookup(via) |
There was a problem hiding this comment.
use switch and simple methods call to notify lib instead of all these ext points and boiler plate.
ashiquzzaman33
force-pushed
the
notify_admin_exp_certs
branch
2 times, most recently
from
c5400e1
to
559e24e
Compare
sadlil
suggested changes
Jul 4, 2017
pkg/utils/utils.go
Outdated
| @@ -0,0 +1,35 @@ | |||
| package utils | |||
ashiquzzaman33
force-pushed
the
notify_admin_exp_certs
branch
from
559e24e
to
93088e0
Compare
tamalsaha
requested changes
Jul 4, 2017
pkg/cert/cert_watcher.go
Outdated
| } | ||
| } | ||
|
|
||
| func (c CertWatcher) Run() { |
sadlil
approved these changes
Jul 4, 2017
tamalsaha
added a commit
that referenced
this pull request
Aug 18, 2018
70ef1128 fix branch naming issue (#23) git-subtree-dir: hack/libbuild git-subtree-split: 70ef11282ee43c0ba11ee94e9e3d4d008b82498e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11