Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to insert config sections directly #333

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

pirtoo
Copy link
Contributor

@pirtoo pirtoo commented Jan 10, 2019

Without this ability extra config secrets need to be configured
manually and in an all-helm environment that means an extra chart just
to add a secret. With this addition the config can be put in a local
values file and be used directly by kubed along with the other config
here.

Without this ability extra config secrets need to be configured
manually and in an all-helm environment that means an extra chart just
to add a secret. With this addition the config can be put in a local
values file and be used directly by kubed along with the other config
here.
@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #333   +/-   ##
=====================================
  Coverage     0.9%   0.9%           
=====================================
  Files           5      5           
  Lines         441    441           
=====================================
  Hits            4      4           
  Misses        437    437

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e921b5b...e816d41. Read the comment docs.

@tamalsaha tamalsaha merged commit 38d14dd into config-syncer:master Apr 23, 2019
@tamalsaha
Copy link
Contributor

Thanks @pirtoo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants