add judge before use the array's index #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Zenghui Shi <zshi@redhat.com>
Bug 2021151: Sync master 27 12 21
It is found that VF netdev disappears after it was successfully created (observed via ip link show). While investigating the root cause, setting addtional dependency in NetworkManager.service as temporary fix to the issue. This commits also changes service and script names to lower case Signed-off-by: Zenghui Shi <zshi@redhat.com> (cherry picked from commit 6325355230a16d06426810b8ab1c76cd17a42787)
Bug 2041734: ensure switchdev service dependencies
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
…4.11-sriov-network-webhook Updating sriov-network-webhook images to be consistent with ART
…4.11-sriov-network-config-daemon Updating sriov-network-config-daemon images to be consistent with ART
…4.11-sriov-network-must-gather Updating sriov-network-must-gather images to be consistent with ART
Bump sriov operator image to ocp 4.11
there is no oc command inside the base container so we need to use the cli container Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Fix must-gather container
Substitute SriovNetworkNodeConfigPolicy name with SriovNetworkNodePolicy as it is the name of the struct CR type. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
This patch fixes image build target to tag image 'ghcr.io/k8snetworkplumbingwg/sriov-network-operator:latest' by default. Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
added openshift api module for ease of use with infra topology Signed-off-by: ehila <ehila@redhat.com>
leader election config will query the cluster for the topology and if we are in an SNO toplogy we use one set of configs otherwise we use conventional defaults for HA cluster config. Signed-off-by: ehila <ehila@redhat.com> upkeep: ran go mod tidy/vendor/verify Signed-off-by: ehila <ehila@redhat.com> upkeep: spelling fix Signed-off-by: ehila <ehila@redhat.com> feat: moved sno logic to utils moved sno logic to use the cluster.go file added check for k8s or openshift environment upkeep re-organize imports Signed-off-by: ehila <ehila@redhat.com> feat: added rbac for operator Signed-off-by: ehila <ehila@redhat.com> refactor: updated to use client-go leader election updated to use client-go leader election struct instead of openshift/api updated wording to remove SNO acronym Signed-off-by: ehila <ehila@redhat.com>
This commit removes the pod that is created to validate if the node has secure boot enable or not Before this PR after every test running there are test pods in the sriov operator namespace that does not get clean Signed-off-by: Sebastian Sch <sebassch@gmail.com>
This patch introduces following changes: * explicitly set go version to v1.17 in GitHub actions * updates go.mod file and vendored packages * updates go version in Dockerfiles 'go install' instead of 'go get' [1] will be used once #231 is fixed. [1] https://go.dev/doc/go-get-install-deprecation
Since drain operation started we don't need to requires drain lock for this node because node already has required annotation. It's safe to continue node drain procedure without lock. Closes: #230 Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
PR #223 updated base images to CentOS 8 which is EOL now so we can't build new images using it. Closes: #239
Signed-off-by: Ivan Kolodyazhny <ikolodiazhny@nvidia.com>
updated to attach scheme to client for infra call updated error message output to bubble up error from single node call Signed-off-by: ehila <ehila@redhat.com>
…ver only Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
add default config for sriov-operator
mangement -> management
Update CONTRIBUTING.md
specifc -> specific
Update supported-hardware.md
change function name probeMode -> tryProbeMode
add forked from
…tor into kube-ovn
set mellanox ib vf state to Follow
|
close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add judge before use the array's index, unless the process will crash