Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all injected environment variables on checker pods #450

Closed
integrii opened this issue Apr 30, 2020 · 3 comments
Closed

Document all injected environment variables on checker pods #450

integrii opened this issue Apr 30, 2020 · 3 comments
Assignees
Labels
documentation Related to or primarily documentation
Milestone

Comments

@integrii
Copy link
Collaborator

We should add KH_CHECK_RUN_DEADLINE to this doc along with all the other environment variables that are loaded into pods by KH by default.

@integrii integrii added the documentation Related to or primarily documentation label Apr 30, 2020
@integrii integrii added this to the 2.3.0 milestone Apr 30, 2020
@bavarianbidi
Copy link
Contributor

bavarianbidi commented Apr 30, 2020

have to rework on PR #443 and could add this in my PR if you want?

@integrii
Copy link
Collaborator Author

Sure! Up to you. I tend not to keep adding into PRs because things go wrong and the extraneous changes get dropped by accident. More smaller PRs is normally better practice, I think.

Either way is fine here, though.

@jonnydawg
Copy link
Collaborator

All the crucial ones are documented (all the ones check implementers should be aware about)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to or primarily documentation
Projects
None yet
Development

No branches or pull requests

3 participants