Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQ: Global image prefix #734

Closed
TJM opened this issue Nov 24, 2020 · 3 comments · Fixed by #751
Closed

REQ: Global image prefix #734

TJM opened this issue Nov 24, 2020 · 3 comments · Fixed by #751
Assignees
Labels
feature request A request for a specific feature to be added to Kuberhealthy good first issue Good for newcomers

Comments

@TJM
Copy link
Contributor

TJM commented Nov 24, 2020

Describe the feature you would like and why you want it
Due to the rate limiting that docker.io has implemented, I would like to be able to add a prefix to all docker images that kuberhealthy runs. I could modify several images, but I would like a "global" setting where I could prefix all images with something like artifactory.company.com.

Additional context
Thanks in advance!?

@TJM TJM added the feature request A request for a specific feature to be added to Kuberhealthy label Nov 24, 2020
@TJM
Copy link
Contributor Author

TJM commented Nov 24, 2020

Actually, if we could split the image registry from the repository like this:

image:
  registry: docker.io
  repository: kuberhealthy/kuberhealthy
  tag: 2.3.1

.. that would probably simplify adding a global override:

global:
  imageRegistry: artifactory.company.com

@integrii
Copy link
Collaborator

At the risk of adding too many options to the helm chart, I think this would be useful - even for us in our internal clusters.

I will leave this feature request open for anyone who feels up to the task. Feel free to create a PR with this change in it if you get the time.

@TJM
Copy link
Contributor Author

TJM commented Nov 24, 2020

I will look at how they are doing this on the bitnami charts, as that is where I have recently seen this option. I am currently just updating our helmrelease to have the images listed for each check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a specific feature to be added to Kuberhealthy good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants