Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Manage SSH keys on cluster #1353

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it:
Redesign Manage SSH keys on cluster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1326

Special notes for your reviewer:
/

Release note:

Redesign dialog to manage SSH keys on cluster

@kgroschoff kgroschoff self-assigned this Jul 5, 2019
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2019
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #1353 into master will decrease coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   74.01%   73.97%   -0.04%     
==========================================
  Files         191      191              
  Lines        5583     5587       +4     
  Branches      498      500       +2     
==========================================
+ Hits         4132     4133       +1     
- Misses       1258     1261       +3     
  Partials      193      193
Impacted Files Coverage Δ
...ter-details/edit-sshkeys/edit-sshkeys.component.ts 55.07% <28.57%> (-1.86%) ⬇️
src/app/shared/functions/generate-random-string.ts 84.61% <0%> (-15.39%) ⬇️
.../components/notification/notification.component.ts 84.44% <0%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59675eb...f7a2dc7. Read the comment docs.

@maciaszczykm
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26b4da665a0629d45a626155db8bada8c965ea63

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2019
@kubermatic-bot kubermatic-bot merged commit d814055 into master Jul 5, 2019
@kubermatic-bot kubermatic-bot deleted the redesign/manage-ssh-keys branch July 5, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Manage SSH keys on cluster
3 participants