-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch GCP machine and disk types from API #1363
Conversation
@floreks Thanks, using I will fix the tests now. |
Codecov Report
@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 74.76% 73.75% -1.02%
==========================================
Files 203 203
Lines 5961 6096 +135
Branches 538 562 +24
==========================================
+ Hits 4457 4496 +39
- Misses 1292 1373 +81
- Partials 212 227 +15
Continue to review full report at Codecov.
|
/test pull-dashboard-headless-test |
/lgtm |
LGTM label has been added. Git tree hash: 4cebe0f6f3708ab9006407e86e237af239e71867
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maciaszczykm Could this be cherry-picked into the v1.3 branch or does it also require the presets to be backported into Kubermatic v2.11? |
@kdomanski It requires presets and 2 PRs to the backend (the second one was adding no-credentails endpoints). |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1322.Special notes for your reviewer:
Release note: