Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch GCP machine and disk types from API #1363

Merged
merged 13 commits into from
Jul 12, 2019
Merged

Fetch GCP machine and disk types from API #1363

merged 13 commits into from
Jul 12, 2019

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Jul 8, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1322.

Special notes for your reviewer:

Release note:

GCP machine and disk types are now fetched from GCP.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2019
@maciaszczykm maciaszczykm changed the title [WIP] Fetch GCP provider data from API Fetch GCP machine and disk types from API Jul 10, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2019
@maciaszczykm
Copy link
Contributor Author

@floreks Thanks, using private makes a lot of sense, sometimes I forgot to do it though :)

I will fix the tests now.

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #1363 into master will decrease coverage by 1.01%.
The diff coverage is 35.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   74.76%   73.75%   -1.02%     
==========================================
  Files         203      203              
  Lines        5961     6096     +135     
  Branches      538      562      +24     
==========================================
+ Hits         4457     4496      +39     
- Misses       1292     1373      +81     
- Partials      212      227      +15
Impacted Files Coverage Δ
src/app/shared/model/NodeProviderConstants.ts 91.66% <100%> (-0.93%) ⬇️
...node-data/gcp-node-data/gcp-node-data.component.ts 41.44% <33.33%> (-24.07%) ⬇️
src/app/core/services/api/api.service.ts 35.53% <33.33%> (-0.75%) ⬇️
src/app/core/services/wizard/provider/gcp.ts 51.51% <41.66%> (-34.2%) ⬇️
src/app/testing/services/api-mock.service.ts 72.04% <50%> (-1%) ⬇️
src/app/shared/entity/HealthEntity.ts 86.66% <0%> (-13.34%) ⬇️
src/app/member/member.component.ts 73.33% <0%> (-2.67%) ⬇️
...uster/cluster-details/cluster-details.component.ts 70.07% <0%> (-0.56%) ⬇️
...tails/cluster-secrets/cluster-secrets.component.ts 89.09% <0%> (-0.2%) ⬇️
src/app/testing/fake-data/health.fake.ts 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87cdc67...38439a3. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/test pull-dashboard-headless-test

@floreks
Copy link
Contributor

floreks commented Jul 12, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4cebe0f6f3708ab9006407e86e237af239e71867

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@kubermatic-bot kubermatic-bot merged commit 116646a into master Jul 12, 2019
@kubermatic-bot kubermatic-bot deleted the gcp-fetch branch July 12, 2019 12:37
@kdomanski
Copy link
Contributor

@maciaszczykm Could this be cherry-picked into the v1.3 branch or does it also require the presets to be backported into Kubermatic v2.11?

@maciaszczykm
Copy link
Contributor Author

@kdomanski It requires presets and 2 PRs to the backend (the second one was adding no-credentails endpoints).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCE] get the list of node sizes from API
4 participants