Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Wizard: Summary #1409

Merged
merged 14 commits into from
Aug 1, 2019
Merged

Redesign Wizard: Summary #1409

merged 14 commits into from
Aug 1, 2019

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it:
Redesign Wizard: Summary
Also fixed some minor issues:

  • Machine Networks field DNS Servers had misplaced label
  • hide Extended Tab for Packet
  • moved checkboxes from right to left

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1324

Special notes for your reviewer:
summary-view

Release note:

Redesign Wizard: Summary

@kgroschoff kgroschoff self-assigned this Jul 24, 2019
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 24, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited
Loading

Codecov Report

Merging #1409 into master will decrease coverage by 0.17%.
The diff coverage is 26.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage    73.4%   73.23%   -0.18%     
==========================================
  Files         205      205              
  Lines        6288     6299      +11     
  Branches      582      589       +7     
==========================================
- Hits         4616     4613       -3     
- Misses       1428     1444      +16     
+ Partials      244      242       -2
Impacted Files Coverage Δ
src/app/wizard/summary/summary.component.ts 57.89% <26.92%> (-25.83%) ⬇️
.../app/wizard/set-settings/set-settings.component.ts 71.42% <0%> (-14.29%) ⬇️
src/app/sshkey/sshkey.component.ts 88.23% <0%> (-0.18%) ⬇️
src/app/core/services/project/project.service.ts 45% <0%> (ø) ⬆️
src/app/serviceaccount/serviceaccount.component.ts 75.26% <0%> (ø) ⬆️
src/app/core/services/user/user.service.ts 56.66% <0%> (ø) ⬆️
src/app/wizard/wizard.component.ts 47.43% <0%> (+0.3%) ⬆️
src/app/core/services/cluster/cluster.service.ts 37.07% <0%> (+0.41%) ⬆️
...uster/cluster-details/cluster-details.component.ts 70.76% <0%> (+0.69%) ⬆️
...-data/azure-node-data/azure-node-data.component.ts 62.37% <0%> (+0.99%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f51a4...8bf7826. Read the comment docs.

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

2 similar comments
@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff kgroschoff mentioned this pull request Jul 26, 2019
Closed
24 tasks
@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

@maciaszczykm PTAL 😃

@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2019
@maciaszczykm
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c4d03b1159ab391e4de980449ca3393aa3dcad5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kubermatic-bot kubermatic-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2019
@kgroschoff kgroschoff added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@kgroschoff
Copy link
Contributor Author

/retest

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

4 similar comments
@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-headless-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

3 similar comments
@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kgroschoff
Copy link
Contributor Author

/test pull-dashboard-e2e-test

@kubermatic-bot kubermatic-bot merged commit 511e01a into master Aug 1, 2019
@kubermatic-bot kubermatic-bot deleted the redesign/wizard-summary branch August 1, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

Assignees

@maciaszczykm maciaszczykm

@kgroschoff kgroschoff

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kgroschoff @maciaszczykm @kubermatic-bot