Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides cluster type toggle in wizard if only one cluster type is active #1425

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

bashofmann
Copy link
Contributor

What this PR does / why we need it:

Hides cluster type toggle in wizard if only one cluster type is active.
Also the default type is set to Openshift if Kubernetes is not active.

Release note:

Cluster type toggle in wizard is now hidden if only one cluster type is active

@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 29, 2019
@kubermatic-bot
Copy link
Contributor

Hi @bashofmann. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2019
@floreks
Copy link
Contributor

floreks commented Jul 29, 2019

/test all

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #1425 into master will decrease coverage by 0.16%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   73.02%   72.86%   -0.17%     
==========================================
  Files         206      207       +1     
  Lines        6377     6482     +105     
  Branches      601      620      +19     
==========================================
+ Hits         4657     4723      +66     
- Misses       1472     1503      +31     
- Partials      248      256       +8
Impacted Files Coverage Δ
...ard/set-cluster-spec/set-cluster-spec.component.ts 86.27% <85.71%> (+1.49%) ⬆️
...ata/packet-node-data/packet-node-data.component.ts 57.47% <0%> (-23.61%) ⬇️
src/app/sshkey/sshkey.component.ts 85.29% <0%> (-2.95%) ⬇️
src/app/core/services/wizard/provider/packet.ts 79.16% <0%> (-2.66%) ⬇️
...uster/cluster-details/cluster-details.component.ts 69.11% <0%> (-1.66%) ⬇️
src/app/shared/model/NodeProviderConstants.ts 90.47% <0%> (-0.44%) ⬇️
src/app/core/services/api/api.service.ts 36.76% <0%> (-0.08%) ⬇️
src/app/testing/fake-data/addNodeModal.fake.ts 100% <0%> (ø) ⬆️
...ter-details/edit-cluster/edit-cluster.component.ts 100% <0%> (ø)
...firmation/cluster-delete-confirmation.component.ts 95% <0%> (+0.55%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc0fab...36a086c. Read the comment docs.

Also the default type is set to Openshift if Kubernetes is not active
@bashofmann bashofmann force-pushed the feature/improve-type-toggle-in-wizard branch from 4bdf6e9 to 36a086c Compare August 8, 2019 12:43
@kgroschoff
Copy link
Contributor

/test all

@kgroschoff
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d57b3efdbfe3edac3e73aa008901073a7144c3f9

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@kubermatic-bot kubermatic-bot merged commit 28690cc into master Aug 12, 2019
@kubermatic-bot kubermatic-bot deleted the feature/improve-type-toggle-in-wizard branch August 12, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants