Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new field Control plane role (ARN) to AWS #1512

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it:
Add new field Control plane role (ARN) to AWS

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1486

Special notes for your reviewer:
/

Release note:

Setting `Control plane role (ARN)` on AWS is possible now

@kgroschoff kgroschoff self-assigned this Aug 27, 2019
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 27, 2019
@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 27, 2019
@maciaszczykm
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ffc55e9faac4883eacf656c490e8d7c94cdb3e6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@kubermatic-bot kubermatic-bot merged commit a9c1ad1 into master Aug 27, 2019
@kubermatic-bot kubermatic-bot deleted the feature/aws-add-roleARN branch August 27, 2019 09:27
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1512   +/-   ##
=======================================
  Coverage   71.86%   71.86%           
=======================================
  Files         208      208           
  Lines        6646     6646           
  Branches      660      660           
=======================================
  Hits         4776     4776           
  Misses       1610     1610           
  Partials      260      260
Impacted Files Coverage Δ
src/app/testing/fake-data/cluster.fake.ts 95.83% <ø> (ø) ⬆️
...et-settings/provider-settings/aws/aws.component.ts 44.79% <ø> (ø) ⬆️
src/app/wizard/summary/summary.component.ts 57.89% <ø> (ø) ⬆️
src/app/shared/entity/ClusterEntity.ts 61.76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7b495...e95ad67. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1512   +/-   ##
=======================================
  Coverage   71.86%   71.86%           
=======================================
  Files         208      208           
  Lines        6646     6646           
  Branches      660      660           
=======================================
  Hits         4776     4776           
  Misses       1610     1610           
  Partials      260      260
Impacted Files Coverage Δ
src/app/testing/fake-data/cluster.fake.ts 95.83% <ø> (ø) ⬆️
...et-settings/provider-settings/aws/aws.component.ts 44.79% <ø> (ø) ⬆️
src/app/wizard/summary/summary.component.ts 57.89% <ø> (ø) ⬆️
src/app/shared/entity/ClusterEntity.ts 61.76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7b495...e95ad67. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting the roleARN field for AWS clusters
3 participants