-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new field Control plane role (ARN) to AWS #1512
Conversation
/lgtm |
LGTM label has been added. Git tree hash: 8ffc55e9faac4883eacf656c490e8d7c94cdb3e6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1512 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 208 208
Lines 6646 6646
Branches 660 660
=======================================
Hits 4776 4776
Misses 1610 1610
Partials 260 260
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1512 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 208 208
Lines 6646 6646
Branches 660 660
=======================================
Hits 4776 4776
Misses 1610 1610
Partials 260 260
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Add new field
Control plane role (ARN)
to AWSWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1486
Special notes for your reviewer:
/
Release note: