Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align azure spec with the API #2547

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Align azure spec with the API #2547

merged 4 commits into from
Jan 12, 2021

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Aug 10, 2020

What this PR does / why we need it:
Blocked by kubermatic/kubermatic#5745

Changes

  • zones field is now a list of strings instead of a single zone string
  • added support for selecting multiple options to our km-combobox. There is a new input called multiple.
  • aligned azure spec with the API and added 2 new optional fields to the azure provider:
    • OS Disk Size
    • Data Disk Size
  • fixed an issue with reloading some wizard fields when global admin settings were changed by someone else

Zrzut ekranu z 2021-01-12 14-11-57

Zrzut ekranu z 2021-01-12 14-20-58

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2432

Release note:

Add the option to specify OS/data disk size for Azure clusters and support selection of multiple zones.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 10, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2020
@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de7c4de55b966b5e1cdcd054daf2eecf7e199ba4

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@floreks floreks marked this pull request as draft August 10, 2020 10:19
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2020
@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2020
@floreks floreks added the lifecycle/blocked Denotes an issue or PR is blocked. label Sep 30, 2020
@maciaszczykm maciaszczykm removed their assignment Dec 17, 2020
@kubermatic-bot kubermatic-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 12, 2021
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2021
@floreks floreks marked this pull request as ready for review January 12, 2021 13:38
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2021
@floreks
Copy link
Contributor Author

floreks commented Jan 12, 2021

/hold cancel

@floreks floreks removed the lifecycle/blocked Denotes an issue or PR is blocked. label Jan 12, 2021
@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f7d864197b7f4d8bc78c8fd063089df1670836ef

@floreks
Copy link
Contributor Author

floreks commented Jan 12, 2021

Waiting for the API to get merged first.

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #2547 (c37ba5c) into master (e683021) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2547      +/-   ##
==========================================
- Coverage   52.39%   52.38%   -0.01%     
==========================================
  Files         237      237              
  Lines        8201     8204       +3     
  Branches      985      985              
==========================================
+ Hits         4297     4298       +1     
- Misses       3901     3903       +2     
  Partials        3        3              
Impacted Files Coverage Δ
src/app/shared/entity/node.ts 45.45% <ø> (ø)
src/app/testing/fake-data/node.fake.ts 68.18% <ø> (ø)
src/app/shared/components/combobox/component.ts 44.06% <66.66%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e683021...c37ba5c. Read the comment docs.

@floreks
Copy link
Contributor Author

floreks commented Jan 12, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2021
@kubermatic-bot kubermatic-bot merged commit 178f58d into kubermatic:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure spec differs from the API
4 participants