Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new cluster endpoints without seed param #2641

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Sep 18, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #2438

Special notes for your reviewer:

Release note:

Switched to new cluster endpoints.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 18, 2020
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2020
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review September 21, 2020 11:39
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @floreks

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #2641 into master will increase coverage by 0.01%.
The diff coverage is 12.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
+ Coverage   52.47%   52.48%   +0.01%     
==========================================
  Files         234      234              
  Lines        8191     8189       -2     
  Branches      998      986      -12     
==========================================
  Hits         4298     4298              
+ Misses       3890     3888       -2     
  Partials        3        3              
Impacted Files Coverage Δ
...d-machine-network/add-machine-network.component.ts 61.90% <0.00%> (-0.89%) ⬇️
...firmation/cluster-delete-confirmation.component.ts 93.10% <ø> (ø)
...uster/cluster-details/cluster-details.component.ts 53.80% <ø> (ø)
...nt-details/machine-deployment-details.component.ts 40.17% <ø> (ø)
...orks-display/machine-networks-display.component.ts 42.85% <ø> (+1.94%) ⬆️
src/app/core/services/cluster/cluster.service.ts 17.85% <0.00%> (ø)
...app/core/services/page-title/page-title.service.ts 22.95% <6.25%> (+1.41%) ⬆️
src/app/core/services/params/params.service.ts 50.00% <20.00%> (-4.17%) ⬇️
...luster-version/change-cluster-version.component.ts 97.77% <100.00%> (ø)
...ter-details/edit-cluster/edit-cluster.component.ts 86.56% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bfe10...6ce5fb7. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2020
@maciaszczykm
Copy link
Contributor Author

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2020
Copy link
Contributor

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f6460df03f71d7529a450eadfc35ab73f5d7ff5

@kubermatic-bot kubermatic-bot merged commit 0a107c0 into kubermatic:master Sep 22, 2020
@maciaszczykm maciaszczykm deleted the feature/v2-endpoints branch September 22, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants