Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browsers support #2668

Merged
merged 9 commits into from
Sep 28, 2020

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Sep 28, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2660

Special notes for your reviewer:

➜ browserslist
and_chr 85
and_ff 79
chrome 85
chrome 84
edge 85
edge 84
firefox 81
firefox 80
ios_saf 14.0
ios_saf 13.4-13.7
safari 14
safari 13.1

➜ browserslist --coverage       
These browsers account for 72% of all users globally

Release note:

Improve browsers support.

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 28, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2020
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2020
@maciaszczykm maciaszczykm changed the title Add browserlist Improve browser support Sep 28, 2020
@maciaszczykm maciaszczykm changed the title Improve browser support Improve browsers support Sep 28, 2020
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2020
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review September 28, 2020 09:29
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2020
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2020
@maciaszczykm
Copy link
Contributor Author

maciaszczykm commented Sep 28, 2020

I've added an issue for the core repo: kubermatic/kubermatic#5958

@kubermatic-bot kubermatic-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2020
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 28, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @kgroschoff @floreks

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2668 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2668   +/-   ##
=======================================
  Coverage   52.42%   52.42%           
=======================================
  Files         234      234           
  Lines        8213     8213           
  Branches      990      990           
=======================================
  Hits         4306     4306           
  Misses       3904     3904           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fb4fc...e4c0f26. Read the comment docs.

@floreks
Copy link
Contributor

floreks commented Sep 28, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d19d73df282936671520c72b26c5407608c49c5

@kubermatic-bot kubermatic-bot merged commit f73b442 into kubermatic:master Sep 28, 2020
@maciaszczykm maciaszczykm deleted the feature/browserlist branch September 28, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare a list of supported browsers
4 participants