Update cluster resource loading states #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
dco-signoff: yes
kubermatic-bot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
- Coverage 52.41% 52.37% -0.05%
==========================================
Files 234 235 +1
Lines 8215 8226 +11
Branches 991 996 +5
==========================================
+ Hits 4306 4308 +2
- Misses 3906 3915 +9
Partials 3 3
Continue to review full report at Codecov.
|
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
/assign @kgroschoff @floreks |
floreks
reviewed
Oct 6, 2020
|
/lgtm |
|
LGTM label has been added. Git tree hash: 0ddccc0527c94a51b26e1b8cdc58ba698d18c362
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2609
Special notes for your reviewer:
At the moment it is added only for cluster resources as mentioned in the issue. @cschieder if we want to use it in more places please let us know about them in a separate issue.
Release note: