Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster search/filter #2695

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2694

Special notes for your reviewer:

Release note:

Add option to filter clusters.

Marcin Maciaszczyk added 3 commits October 7, 2020 12:32
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 7, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Oct 7, 2020
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2020
@maciaszczykm maciaszczykm marked this pull request as ready for review October 9, 2020 08:09
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @floreks @kgroschoff

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #2695 into master will decrease coverage by 0.10%.
The diff coverage is 28.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
- Coverage   52.37%   52.26%   -0.11%     
==========================================
  Files         235      236       +1     
  Lines        8226     8264      +38     
  Branches      996     1003       +7     
==========================================
+ Hits         4308     4319      +11     
- Misses       3915     3942      +27     
  Partials        3        3              
Impacted Files Coverage Δ
src/app/shared/entity/cluster.ts 63.02% <0.00%> (-0.54%) ⬇️
...app/cluster/cluster-list/cluster-list.component.ts 58.66% <8.33%> (-9.59%) ⬇️
...rc/app/shared/components/search-field/component.ts 66.66% <66.66%> (ø)
src/app/shared/shared.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4bd170...db3aa61. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

@kgroschoff Can you review it?

@kgroschoff
Copy link
Contributor

Works like a charm, nice work 👍
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a1cc32b92ae96e5fa200400e87d13e4986333ac

@kubermatic-bot kubermatic-bot merged commit e128555 into kubermatic:master Oct 15, 2020
@maciaszczykm maciaszczykm deleted the feature/cluster-filter branch October 15, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search/Filter for Clusters
4 participants