Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datastore support to vsphere provider #2762

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Add datastore support to vsphere provider #2762

merged 1 commit into from
Nov 3, 2020

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Nov 2, 2020

What this PR does / why we need it:

  • Added Datastore and Datastore Cluster support to vsphere provider in wizard
  • Fix summary view layout

Which issue(s) this PR fixes:
Fixes #2611

Release note:

Add Datastore/Datastore Cluster support to the VSphere provider in the wizard.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 2, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #2762 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
- Coverage   52.32%   51.63%   -0.69%     
==========================================
  Files         234      234              
  Lines        8211     8413     +202     
  Branches      981     1016      +35     
==========================================
+ Hits         4296     4344      +48     
- Misses       3912     4066     +154     
  Partials        3        3              
Impacted Files Coverage Δ
src/app/shared/entity/cluster.ts 57.57% <ø> (ø)
.../cluster/cluster-details/edit-sshkeys/component.ts 35.71% <0.00%> (-8.04%) ⬇️
src/app/cluster/cluster-details/component.ts 51.43% <0.00%> (-3.03%) ⬇️
src/app/cluster/cluster-list/component.ts 57.21% <0.00%> (-2.91%) ⬇️
src/app/core/services/api/service.ts 3.73% <0.00%> (-1.50%) ⬇️
src/app/cluster/services/node.service.ts 45.94% <0.00%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291d9b0...087cb8c. Read the comment docs.

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f1f53edbc8408bb99aedf099d443747054300554

@kubermatic-bot kubermatic-bot merged commit 785952e into kubermatic:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vSphere] Add UI support for Datastore and DatastoreCluster
3 participants