Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.15] Revert "Remove list of orphaned nodes from cluster view (#2574)" #2774

Merged

Conversation

maciaszczykm
Copy link
Contributor

This reverts commit 73aa222

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
/assign @floreks

Release note:

Restore list of nodes in the cluster view.

@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 5, 2020
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2020
@floreks
Copy link
Contributor

floreks commented Nov 5, 2020

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c1fa7a5e07c89a1213e8003e3c61beed3f4ddc89

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #2774 into release/v2.15 will decrease coverage by 0.05%.
The diff coverage is 34.78%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v2.15    #2774      +/-   ##
=================================================
- Coverage          52.49%   52.43%   -0.06%     
=================================================
  Files                234      234              
  Lines               8188     8220      +32     
  Branches             999      960      -39     
=================================================
+ Hits                4298     4310      +12     
- Misses              3887     3907      +20     
  Partials               3        3              
Impacted Files Coverage Δ
...pp/core/components/navigation/project/component.ts 36.17% <0.00%> (ø)
src/app/project/project.module.ts 100.00% <ø> (ø)
...mponents/external-cluster-data-dialog/component.ts 47.36% <0.00%> (ø)
src/app/shared/entity/addon.ts 60.00% <ø> (ø)
src/app/shared/entity/settings.ts 83.67% <ø> (ø)
src/app/shared/services/cluster.service.ts 22.22% <0.00%> (-0.97%) ⬇️
src/app/testing/services/settings-mock.service.ts 81.81% <ø> (ø)
src/app/wizard/step/cluster/ssh-keys/component.ts 72.58% <ø> (ø)
...error-notifications/error-notifications.service.ts 25.92% <6.66%> (-9.08%) ⬇️
...t/edit-addon-dialog/edit-addon-dialog.component.ts 33.33% <33.33%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e507ee...2bf5ee7. Read the comment docs.

@kubermatic-bot kubermatic-bot merged commit 61f9752 into kubermatic:release/v2.15 Nov 5, 2020
@maciaszczykm maciaszczykm deleted the fix/cluster-node branch November 5, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants