Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing all projects #2848

Merged

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2826

Special notes for your reviewer:

Release note:

Fixed issue with listing all projects if one of them had no owner set.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 8, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm maciaszczykm self-assigned this Dec 8, 2020
@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2020
@maciaszczykm
Copy link
Contributor Author

/assign @floreks

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #2848 (f8c7801) into master (f9494c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2848   +/-   ##
=======================================
  Coverage   52.35%   52.35%           
=======================================
  Files         234      234           
  Lines        8188     8188           
  Branches      939      940    +1     
=======================================
  Hits         4287     4287           
  Misses       3898     3898           
  Partials        3        3           
Impacted Files Coverage Δ
src/app/project/project.component.ts 69.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9494c0...f8c7801. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/retest

@floreks
Copy link
Contributor

floreks commented Dec 8, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: be52ce9321ec5c17d00981530b615c56a5d326a5

@kubermatic-bot kubermatic-bot merged commit d2178be into kubermatic:master Dec 8, 2020
@maciaszczykm maciaszczykm deleted the fix/list-all-projects branch December 8, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot show all projects
3 participants