Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group display name logic #2851

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix group display name logic #2851

merged 1 commit into from
Dec 9, 2020

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Dec 8, 2020

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2803

Release note:

Fix missing group name on Service Account list.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 8, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2020
@floreks floreks self-assigned this Dec 8, 2020
@floreks floreks assigned maciaszczykm and unassigned floreks Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #2851 (cb43532) into master (54f37b7) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
+ Coverage   52.35%   52.47%   +0.11%     
==========================================
  Files         234      234              
  Lines        8188     8189       +1     
  Branches      939      939              
==========================================
+ Hits         4287     4297      +10     
+ Misses       3898     3890       -8     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/app/shared/utils/member-utils/member-utils.ts 85.29% <100.00%> (+0.44%) ⬆️
src/app/project/project.component.ts 73.16% <0.00%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f37b7...cb43532. Read the comment docs.

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc4cbca56f0e76a0086be296e4a232bea0c7c15a

@kubermatic-bot kubermatic-bot merged commit 9321467 into kubermatic:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups for Service Accounts is not shown
3 participants