-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Preset Management UI #2880
Add Preset Management UI #2880
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2880 +/- ##
==========================================
- Coverage 52.39% 52.37% -0.02%
==========================================
Files 237 237
Lines 8201 8519 +318
Branches 985 1060 +75
==========================================
+ Hits 4297 4462 +165
- Misses 3901 4054 +153
Partials 3 3
Continue to review full report at Codecov.
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of work done here 👍🏻 Codewise I have only one remark, I will do some more manual tests.
/lgtm |
LGTM label has been added. Git tree hash: 5816bb51ad23c4062d9587e81001e09dc9bfcfae
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2798
Release note: