Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Preset Management UI #2880

Merged
merged 10 commits into from
Jan 15, 2021
Merged

Add Preset Management UI #2880

merged 10 commits into from
Jan 15, 2021

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Dec 16, 2020

What this PR does / why we need it:

  • List presets for all providers
  • List presets for the selected provider
    • Filter by datacenter
  • Create a preset for the provider
    • Restrict preset to selected datacenter
    • Mark created preset as enabled/disabled
  • Update (override) existing provider preset information
    • Enable/disable preset
    • Update/remove datacenter restriction

Which issue(s) this PR fixes:
Fixes #2798

Release note:

Added Preset management UI to the admin settings.

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 16, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@floreks floreks marked this pull request as draft December 16, 2020 14:44
@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2020
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #2880 (f9a8f2f) into master (5bd1e95) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
- Coverage   52.39%   52.37%   -0.02%     
==========================================
  Files         237      237              
  Lines        8201     8519     +318     
  Branches      985     1060      +75     
==========================================
+ Hits         4297     4462     +165     
- Misses       3901     4054     +153     
  Partials        3        3              
Impacted Files Coverage Δ
src/app/shared/validators/base-form.validator.ts 63.63% <0.00%> (-14.15%) ⬇️
src/app/wizard/service/wizard.ts 20.00% <ø> (ø)
src/app/core/services/wizard/presets.service.ts 27.86% <5.88%> (-6.75%) ⬇️
src/app/shared/model/NodeProviderConstants.ts 63.63% <33.33%> (-2.22%) ⬇️
src/app/wizard/config.ts 87.50% <66.66%> (-12.50%) ⬇️
...ccount-token/add-serviceaccount-token.component.ts 50.00% <0.00%> (-12.07%) ⬇️
...count-token/edit-serviceaccount-token.component.ts 62.96% <0.00%> (-10.96%) ⬇️
...ettings/admin/admins/add-admin-dialog/component.ts 28.57% <0.00%> (-8.93%) ⬇️
src/app/shared/components/combobox/component.ts 36.25% <0.00%> (-8.40%) ⬇️
src/app/testing/fake-data/node.fake.ts 62.50% <0.00%> (-5.69%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd1e95...f9a8f2f. Read the comment docs.

@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 25, 2020
@kubermatic-bot kubermatic-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2021
@floreks floreks changed the title [WIP] Add Preset Management UI Add Preset Management UI Jan 11, 2021
@floreks
Copy link
Contributor Author

floreks commented Jan 11, 2021

/retest

1 similar comment
@floreks
Copy link
Contributor Author

floreks commented Jan 11, 2021

/retest

@floreks floreks marked this pull request as ready for review January 11, 2021 12:49
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2021
Copy link
Contributor

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of work done here 👍🏻 Codewise I have only one remark, I will do some more manual tests.

@floreks floreks self-assigned this Jan 13, 2021
@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5816bb51ad23c4062d9587e81001e09dc9bfcfae

@kubermatic-bot kubermatic-bot merged commit 09e6ef3 into kubermatic:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Presets Management in the Admin Panel
3 participants