Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove labels when pressing enter key in the label form #2903

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it: The behavior was invalid because the delete button was by default acting like submit button. Adding type "button" to it fixes the issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2891

Special notes for your reviewer:

Release note:

Fixed the bug with labels that were removed from form after pressing enter key.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 4, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2021
@maciaszczykm
Copy link
Contributor Author

/assign @floreks

@floreks
Copy link
Contributor

floreks commented Jan 4, 2021

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9bccca1b813142c58b7b2c977323081a0343bb5e

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #2903 (885b636) into master (20c31de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2903   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files         237      237           
  Lines        8201     8201           
  Branches      985      985           
=======================================
  Hits         4297     4297           
  Misses       3901     3901           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c31de...885b636. Read the comment docs.

@kubermatic-bot kubermatic-bot merged commit 2fa6080 into kubermatic:master Jan 4, 2021
@maciaszczykm maciaszczykm deleted the fix/labels-form branch January 5, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last label dissapears from form after pressing enter
3 participants