Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack wizard: pre-fill username and domain fields #2928

Merged

Conversation

multi-io
Copy link
Contributor

@multi-io multi-io commented Jan 12, 2021

Signed-off-by: Olaf Klischat o.klischat@syseleven.de

What this PR does / why we need it:

This pre-fills the username and domain name fields in the cluster creation wizard / openstack settings with the user's login name (for the username) and a default domain name (configurable in a new option in the dashboard config file).

I think these things were there in 2.14. (at least the username thing)

What I'd also like (and was also there in 2.14 I think) would be after the project is selected and the floating IP pool list loaded, to pre-select the first floating ip pool if there's only one. But I couldn't get that to work, so maybe later in a separate PR.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Wizard/Openstack: Fill the form with defaults for username and domain name

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 12, 2021
@kubermatic-bot
Copy link
Contributor

Hi @multi-io. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2021
Copy link
Contributor

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @multi-io. Thanks for your PR.
I remember this feature and I think it was removed by accident with the implementation of the new wizard.
For your PR I only have a small remark, otherwise it is looking good. 😃

Signed-off-by: Olaf Klischat <o.klischat@syseleven.de>
@multi-io multi-io force-pushed the wizard-openstack-prefill-form branch from 7153030 to 3def628 Compare January 15, 2021 11:43
@multi-io
Copy link
Contributor Author

All fixed and pushed.

@floreks
Copy link
Contributor

floreks commented Jan 19, 2021

/test all

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #2928 (3def628) into master (8ecef9f) will decrease coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2928      +/-   ##
==========================================
- Coverage   52.39%   51.43%   -0.96%     
==========================================
  Files         237      238       +1     
  Lines        8201     8542     +341     
  Branches      985     1058      +73     
==========================================
+ Hits         4297     4394      +97     
- Misses       3901     4145     +244     
  Partials        3        3              
Impacted Files Coverage Δ
src/app/shared/validators/base-form.validator.ts 63.63% <0.00%> (-14.15%) ⬇️
src/app/wizard/config.ts 87.50% <0.00%> (-12.50%) ⬇️
src/app/core/services/wizard/presets.service.ts 27.86% <0.00%> (-6.75%) ⬇️
...count-token/edit-serviceaccount-token.component.ts 68.00% <0.00%> (-5.92%) ⬇️
src/app/member/add-member/add-member.component.ts 95.00% <0.00%> (-5.00%) ⬇️
...add-project-dialog/add-project-dialog.component.ts 95.23% <0.00%> (-4.77%) ⬇️
...add-serviceaccount/add-serviceaccount.component.ts 95.45% <0.00%> (-4.55%) ⬇️
...rc/app/member/edit-member/edit-member.component.ts 95.65% <0.00%> (-4.35%) ⬇️
...ettings/admin/admins/add-admin-dialog/component.ts 33.33% <0.00%> (-4.17%) ⬇️
...it-serviceaccount/edit-serviceaccount.component.ts 95.83% <0.00%> (-4.17%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ecef9f...3def628. Read the comment docs.

Copy link
Contributor

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73a330280c30daf366abec022b874ce375a3cb55

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff, multi-io

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021
@kubermatic-bot kubermatic-bot merged commit 3b6100d into kubermatic:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants