-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openstack wizard: pre-fill username and domain fields #2928
openstack wizard: pre-fill username and domain fields #2928
Conversation
Hi @multi-io. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @multi-io. Thanks for your PR.
I remember this feature and I think it was removed by accident with the implementation of the new wizard.
For your PR I only have a small remark, otherwise it is looking good. 😃
src/app/wizard/step/provider-settings/provider/basic/openstack/component.ts
Show resolved
Hide resolved
src/app/wizard/step/provider-settings/provider/basic/openstack/component.ts
Outdated
Show resolved
Hide resolved
src/app/wizard/step/provider-settings/provider/basic/openstack/component.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Olaf Klischat <o.klischat@syseleven.de>
7153030
to
3def628
Compare
All fixed and pushed. |
/test all |
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
==========================================
- Coverage 52.39% 51.43% -0.96%
==========================================
Files 237 238 +1
Lines 8201 8542 +341
Branches 985 1058 +73
==========================================
+ Hits 4297 4394 +97
- Misses 3901 4145 +244
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 73a330280c30daf366abec022b874ce375a3cb55
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgroschoff, multi-io The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Olaf Klischat o.klischat@syseleven.de
What this PR does / why we need it:
This pre-fills the username and domain name fields in the cluster creation wizard / openstack settings with the user's login name (for the username) and a default domain name (configurable in a new option in the dashboard config file).
I think these things were there in 2.14. (at least the username thing)
What I'd also like (and was also there in 2.14 I think) would be after the project is selected and the floating IP pool list loaded, to pre-select the first floating ip pool if there's only one. But I couldn't get that to work, so maybe later in a separate PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: