Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use endpoint to load Azure subnets #2988

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

maciaszczykm
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2919

Special notes for your reviewer:

Release note:

Use endpoint to load Azure subnets autocompletions.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 20, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@maciaszczykm maciaszczykm marked this pull request as draft January 20, 2021 11:15
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #2988 (5a5130d) into master (622b3a1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2988      +/-   ##
==========================================
- Coverage   51.87%   51.85%   -0.02%     
==========================================
  Files         237      237              
  Lines        8326     8329       +3     
  Branches     1022     1022              
==========================================
  Hits         4319     4319              
- Misses       4004     4007       +3     
  Partials        3        3              
Impacted Files Coverage Δ
src/app/core/services/wizard/provider/azure.ts 12.61% <0.00%> (ø)
src/app/core/services/api/service.ts 5.11% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622b3a1...5a5130d. Read the comment docs.

@maciaszczykm
Copy link
Contributor Author

/assign @kgroschoff @floreks

This adds the subnets which are last resource for Azure. Additionally, I've fixed the struct for VNets as by mistake I've used wrong key.

@kubermatic-bot kubermatic-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2021
@maciaszczykm maciaszczykm marked this pull request as ready for review January 20, 2021 12:50
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 20, 2021
Copy link
Contributor

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f824590185e8da1743b8d5955b7a62b99124d2c

@kubermatic-bot kubermatic-bot merged commit 32d43e5 into kubermatic:master Jan 20, 2021
@maciaszczykm maciaszczykm deleted the feature/azure-subnets branch July 26, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use endpoint to list Azure subnets
4 participants