-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use endpoint to load Azure subnets #2988
Use endpoint to load Azure subnets #2988
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2988 +/- ##
==========================================
- Coverage 51.87% 51.85% -0.02%
==========================================
Files 237 237
Lines 8326 8329 +3
Branches 1022 1022
==========================================
Hits 4319 4319
- Misses 4004 4007 +3
Partials 3 3
Continue to review full report at Codecov.
|
/assign @kgroschoff @floreks This adds the subnets which are last resource for Azure. Additionally, I've fixed the struct for VNets as by mistake I've used wrong key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5f824590185e8da1743b8d5955b7a62b99124d2c
|
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2919
Special notes for your reviewer:
Release note: