Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move VSphere diskSizeGB from extended to basic/required options #3121

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Move VSphere diskSizeGB from extended to basic/required options #3121

merged 1 commit into from
Mar 1, 2021

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Mar 1, 2021

What this PR does / why we need it:
Moved VSPhere's diskSizeGB from optional to required options.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3118

Release note:

Changed VSPhere's diskSizeGB option from optional to required.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 1, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2021
@floreks
Copy link
Contributor Author

floreks commented Mar 1, 2021

I guess we should also cherry-pick it.

/cherrypick release/v2.16

@kubermatic-bot
Copy link
Contributor

@floreks: once the present PR merges, I will cherry-pick it on top of release/v2.16 in a new PR and assign it to you.

In response to this:

I guess we should also cherry-pick it.

/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a235f105d376f54662e80d4c6e0601298b4f33b

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #3121 (e91b827) into master (795a3b5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3121   +/-   ##
=======================================
  Coverage   51.71%   51.71%           
=======================================
  Files         243      243           
  Lines        8505     8505           
  Branches      882      882           
=======================================
  Hits         4398     4398           
  Misses       4103     4103           
  Partials        4        4           
Impacted Files Coverage Δ
src/app/node-data/dialog/component.ts 23.52% <0.00%> (ø)
src/app/shared/entity/node.ts 46.98% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795a3b5...e91b827. Read the comment docs.

@floreks
Copy link
Contributor Author

floreks commented Mar 1, 2021

/test pre-dashboard-test-e2e-ce

@floreks
Copy link
Contributor Author

floreks commented Mar 1, 2021

/retest

@kubermatic-bot
Copy link
Contributor

@floreks: new pull request created: #3123

In response to this:

I guess we should also cherry-pick it.

/cherrypick release/v2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Error - vSphere provider (if more then 1 machine deployment is created)
3 participants