-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move VSphere diskSizeGB from extended to basic/required options #3121
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I guess we should also cherry-pick it. /cherrypick release/v2.16 |
@floreks: once the present PR merges, I will cherry-pick it on top of release/v2.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 7a235f105d376f54662e80d4c6e0601298b4f33b
|
Codecov Report
@@ Coverage Diff @@
## master #3121 +/- ##
=======================================
Coverage 51.71% 51.71%
=======================================
Files 243 243
Lines 8505 8505
Branches 882 882
=======================================
Hits 4398 4398
Misses 4103 4103
Partials 4 4
Continue to review full report at Codecov.
|
/test pre-dashboard-test-e2e-ce |
/retest |
@floreks: new pull request created: #3123 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Moved VSPhere's
diskSizeGB
from optional to required options.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3118
Release note: