Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Rule Groups #3971

Merged
merged 14 commits into from Feb 3, 2022
Merged

Admin Rule Groups #3971

merged 14 commits into from Feb 3, 2022

Conversation

kgroschoff
Copy link
Contributor

What this PR does / why we need it

Adds new view "Rule Groups" to Admin Settings

Which issue(s) this PR fixes

Fixes #3873

Special notes for your reviewer

Release note

Admins can define default Rule Groups in Admin Settings

@kgroschoff kgroschoff self-assigned this Dec 20, 2021
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Dec 20, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kgroschoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 20, 2021
@codecov
Copy link

codecov bot commented Dec 20, 2021 •
edited

Codecov Report

Merging #3971 (eca2371) into master (6e5f340) will decrease coverage by 0.13%.
The diff coverage is 25.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3971      +/-   ##
==========================================
- Coverage   51.94%   51.81%   -0.14%     
==========================================
  Files         314      314              
  Lines       11410    11429      +19     
  Branches     1261     1262       +1     
==========================================
- Hits         5927     5922       -5     
- Misses       5481     5505      +24     
  Partials        2        2
Impacted Files Coverage Δ
src/app/core/services/mla.ts 9.09% <0.00%> (-3.88%) ⬇️
src/test/data/mla.ts 100.00% <ø> (ø)
...ter/mla/rule-groups/rule-group-dialog/component.ts 94.36% <85.71%> (-0.08%) ⬇️
...uster/details/cluster/mla/rule-groups/component.ts 79.10% <100.00%> (-1.18%) ⬇️
src/app/shared/entity/mla.ts 100.00% <100.00%> (ø)
src/app/shared/utils/mla.ts 91.66% <0.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5f340...eca2371. Read the comment docs.

@floreks
Copy link
Contributor

floreks commented Dec 20, 2021 •
edited

There is some kind of race condition as the rule groups are not always loading.

image

image

@kgroschoff kgroschoff added this to the KKP 2.19 milestone Dec 23, 2021
@kgroschoff
Copy link
Contributor Author

Sorry @floreks, missed your comment.
I can't reproduce the issue, but i've moved the "get Admin Rule Groups" part, because I can imagine, that this is an issue.
Can you verify if this was the problem?

I don't know if one of you is working until the end of the year, but just in case yes: Would be great if one of you can have a look. I will be back in January, so if you want to hijack the PR, it'll be fine with me. - cc @maciaszczykm

@kgroschoff
Copy link
Contributor Author

@floreks @maciaszczykm PTAL

@kgroschoff kgroschoff removed this from the KKP 2.19 milestone Jan 18, 2022
@kgroschoff
Copy link
Contributor Author

/hold
we need to wait for the backend pr to be merged first.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2022
maciaszczykm
maciaszczykm reviewed Feb 2, 2022
View reviewed changes
src/app/settings/admin/rule-groups/component.ts Outdated
this.adminRuleGroups &&
this.adminRuleGroups.length > 0 &&
this.paginator &&
this.adminRuleGroups.length > this.paginator.pageSize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.adminRuleGroups?.length > this.paginator?.pageSize seems to cover it all assuming that page size is at least equal to 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sounds good to me 👍

@floreks
Copy link
Contributor

floreks commented Feb 2, 2022

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bcb64e450bf3415bb2ce1194b6e767c486d0c95e

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

18 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@floreks floreks added this to the KKP 2.20 milestone Feb 3, 2022
@kubermatic-bot kubermatic-bot merged commit 4d79f0d into kubermatic:master Feb 3, 2022
@kgroschoff kgroschoff deleted the feature/admin-rule-groups branch February 3, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks left review comments

@maciaszczykm maciaszczykm maciaszczykm left review comments

Assignees

@floreks floreks

@kgroschoff kgroschoff

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.20
Development

Successfully merging this pull request may close these issues.

MLA: Add a Tab in admin panel for KKP admins to manage rule groups
5 participants
@kgroschoff @kubermatic-bot @floreks @kubermatic-triage-bot @maciaszczykm