Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and cluster summary redesign #4141

Merged
merged 5 commits into from Jan 31, 2022
Merged

Fixes and cluster summary redesign #4141

merged 5 commits into from Jan 31, 2022

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Jan 31, 2022

What this PR does / why we need it

  • Refactored the cluster list subscription handling
  • Fixed the VSphere datastore/datastore cluster field logic
  • Redesigned cluster summary step
  • Update error notification styling
  • Fixed small issue where auto-expand would not properly work on cluster details

Summary

image

Error notifications

2022-01-31_14-36_1

2022-01-31_14-36

Which issue(s) this PR fixes

Fixes #4135
Fixes #4043
Closes #3927
Closes #4128

Release note

Redesign cluster summary step. Update error notifications and event colors styling.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 31, 2022
@floreks floreks self-assigned this Jan 31, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #4141 (4f28ca1) into master (795a222) will increase coverage by 0.03%.
The diff coverage is 48.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4141      +/-   ##
==========================================
+ Coverage   52.16%   52.19%   +0.03%     
==========================================
  Files         319      317       -2     
  Lines       11460    11435      -25     
  Branches     1516     1507       -9     
==========================================
- Hits         5978     5969       -9     
+ Misses       5164     5148      -16     
  Partials      318      318              
Impacted Files Coverage Δ
...pp/core/components/notification-panel/component.ts 31.70% <0.00%> (ø)
...app/shared/components/cluster-summary/component.ts 22.00% <11.11%> (+3.96%) ⬆️
src/app/cluster/list/cluster/component.ts 67.58% <55.31%> (+0.45%) ⬆️
src/app/cluster/details/cluster/component.ts 50.19% <100.00%> (ø)
src/app/shared/components/tab-card/component.ts 38.09% <0.00%> (ø)
...testing/fake-data/cluster-with-machine-networks.ts
src/app/testing/fake-data/user-group-config.ts
src/app/testing/services/notification-mock.ts
src/app/testing/services/node-mock.ts
src/app/testing/services/feature-gate-mock.ts
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795a222...4f28ca1. Read the comment docs.

@floreks floreks changed the title [WIP] Fixes and cluster summary redesign Fixes and cluster summary redesign Jan 31, 2022
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2022
@maciaszczykm
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef7f0535208c7d44f30d083dd8314bd92eca6569

@maciaszczykm maciaszczykm added this to the KKP 2.20 milestone Jan 31, 2022
@kubermatic kubermatic deleted a comment from kubermatic-bot Jan 31, 2022
@floreks
Copy link
Contributor Author

floreks commented Jan 31, 2022

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit d76297a into kubermatic:master Jan 31, 2022
@floreks floreks deleted the fixes branch March 14, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
4 participants