Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Material Dialog component from legacy to v15 #5921

Closed
Tracked by #5864
Waseem826 opened this issue Apr 26, 2023 · 0 comments · Fixed by #5927
Closed
Tracked by #5864

Migrate Material Dialog component from legacy to v15 #5921

Waseem826 opened this issue Apr 26, 2023 · 0 comments · Fixed by #5927
Assignees
Labels
kind/chore Updating grunt tasks etc; no production code changes. sig/ui Denotes a PR or issue as being assigned to SIG UI.

Comments

@Waseem826
Copy link
Contributor

Waseem826 commented Apr 26, 2023

Migrate Angular Material's Dialog component from legacy to v15 by following instructions in https://github.com/angular/components/blob/main/guides/v15-mdc-migration.md#dialog

  • The .mat-dialog-container does not contain a 24px padding anymore. Instead, the inner dialog directives are responsible for adding the right padding. This will be apparent if your dialog does not use any of the directives like .
  • mat-dialog-content uses the font-settings specified by the Material Design spec, which includes a rather roomy line-height. If you have an information-dense dialog that doesn't look good with these settings, you can avoid using and just use a div with custom padding, or use custom typography settings that can be applied with the mat.mdc-dialog-typography mixin.
  • The old dialog triggered an extra change detection, which may have masked change detection issues in your application that need to be fixed when migrating.
@Waseem826 Waseem826 changed the title Dialog Migrate Dialog component from legacy to v15 Apr 26, 2023
@Waseem826 Waseem826 changed the title Migrate Dialog component from legacy to v15 Migrate Material Dialog component from legacy to v15 Apr 26, 2023
@Waseem826 Waseem826 added kind/feature Categorizes issue or PR as related to a new feature. sig/ui Denotes a PR or issue as being assigned to SIG UI. kind/chore Updating grunt tasks etc; no production code changes. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Apr 26, 2023
@Waseem826 Waseem826 self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Updating grunt tasks etc; no production code changes. sig/ui Denotes a PR or issue as being assigned to SIG UI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant