Support Containerd registry configs in OSM deployment #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
kubermatic-bot
added
sig/api
kubermatic-bot
added
the
size/L
moadqassem
force-pushed
the
add-node-containerd-registry-in-osm
branch
from
8c80f1a
to
209c943
Compare
kubermatic-bot
added
the
sig/app-management
moadqassem
force-pushed
the
add-node-containerd-registry-in-osm
branch
2 times, most recently
from
b92e485
to
5fc7cb5
Compare
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
moadqassem
force-pushed
the
add-node-containerd-registry-in-osm
branch
from
5fc7cb5
to
e5148d3
Compare
moadqassem
requested review from
embik and
zreigz
and removed request for
xrstf and
ahmedwaleedmalik
|
/lgtm |
|
LGTM label has been added. Git tree hash: c7aa8aa6de24a77f8bc5b7b5278ae1a156a49a45
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadqassem, zreigz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/retest |
|
/cherrypick release/v2.20 |
|
@xrstf: new pull request created: #10141 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / Why do we need it:
In OSM, users can configure which container runtime will be installed and how it is configured. For example, configuring the containrd registries and endpoints especially for offline and air-gapped setup. This PR adds the support to configure the operating system manager(osm) to inject these configurations into the machines using osp.
Does this PR close any issues?:
Fixes #
Special notes for your reviewer:
Documentation:
Does this PR introduce a user-facing change?: