New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nil pointer in front loadbalancer creator #10436
fix nil pointer in front loadbalancer creator #10436
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release/v2.20 |
@xrstf: once the present PR merges, I will cherry-pick it on top of release/v2.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM label has been added. Git tree hash: 0f70b00a00da5532dafd5687689d6d714910e8e8
|
/retest |
/retest Review the full test history Silence the bot with an |
@xrstf: new pull request created: #10437 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What does this PR do / Why do we need it:
Defaulting the annotations map happened too late, leading to possible nil pointer panics when custom annotations are configured (a common scenario).
Does this PR introduce a user-facing change?: