Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: add authentification with RegistryConfigFile in HelmCredentials #10564

Merged
merged 2 commits into from Jul 28, 2022
Merged

applications: add authentification with RegistryConfigFile in HelmCredentials #10564

merged 2 commits into from Jul 28, 2022

Conversation

vgramer
Copy link
Contributor

@vgramer vgramer commented Jul 28, 2022

What does this PR do / Why do we need it:
Thsi PR just update the crd and validation, logic will be implemented in next PR

Does this PR close any issues?:
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

NONE

@vgramer vgramer self-assigned this Jul 28, 2022
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2022
@vgramer
applications: add authentification with RegistryConfigFile in HelmCre…
656c5e9 
…dentials

Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
ahmedwaleedmalik
ahmedwaleedmalik reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

pkg/validation/applicationdefinition.go Outdated Show resolved Hide resolved
pkg/validation/applicationdefinition.go Outdated Show resolved Hide resolved
@vgramer @ahmedwaleedmalik
Apply suggestions from code review
dfb7c1b 
Co-authored-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7de3f3859d737ac08d73bf02568a212d756dd7c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, vgramer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@xrstf
Copy link
Contributor

xrstf commented Jul 28, 2022

/hold

temporarily

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2022
@xrstf
Copy link
Contributor

xrstf commented Jul 28, 2022

/hold cancel
/retest

Thanks for waiting.

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2022
@kubermatic-bot kubermatic-bot merged commit e4dd67e into kubermatic:master Jul 28, 2022
@vgramer vgramer deleted the helm-auth-registryfile branch July 28, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@vgramer vgramer

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api Denotes a PR or issue as being assigned to SIG API. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vgramer @kubermatic-bot @xrstf @ahmedwaleedmalik