Applications: helms support registry with autentification #10570
Conversation
…Manager only if necessary (i.e. only if chartLoc is a directory) Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
kubermatic-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vgramer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
vgramer
changed the title
There is 2 kind of possible authentification one with basic auth for http and one that use registryConfigFile for oci. tests has been refactor: ociregistry now take a fileGlob of chart to upload Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
…e we will use it for HelmSource Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
| } | ||
|
|
||
| // AuthFromCredentials builds helmclient.AuthSettings from source.Credentials. registryConfigFilePath is the path of the file that stores credentials for OCI registry. | ||
| func AuthFromCredentials(ctx context.Context, client ctrlruntimeclient.Client, registryConfigFilePath string, secretNamespace string, source *appskubermaticv1.HelmSource) (helmclient.AuthSettings, error) { |
There was a problem hiding this comment.
tiniest nitpick (just because I have nothing else to complain about, because everything's so nice :D)
This could inlcude Helm in the name of the func, since it is in a generic package called util and it does helm specific things
|
LGTM label has been added. Git tree hash: f5677264cb68828d81e30e58bc5fb3e948067e73
|
|
@vgramer: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
What does this PR do / Why do we need it:
This PR adds support for Helm registry with authentication. There is 2 kinds of auth method:
Does this PR close any issues?:
Fixes #9550
Fixes #9776
Special notes for your reviewer:
I recommend a first review by commit because some commits are just refactoring.
Test of HelmTemplate could be improved with authentification tests. But I think I would be better to do it in another PR, it would be the opportunity to switch from ginko to go test
Documentation:
Does this PR introduce a user-facing change?: