Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gimps download #10749

Merged
merged 1 commit into from Aug 15, 2022
Merged

fix gimps download #10749

merged 1 commit into from Aug 15, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 12, 2022 •
edited

What this PR does / why we need it:
gimps 0.5 changed to zipfiles.

/kind bug

Fixes #10734

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2022
@xrstf xrstf added this to the KKP 2.21 milestone Aug 12, 2022
@xrstf xrstf requested a review from mfranczy August 12, 2022 17:21
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b5f153ba7f3984843107afc5577b869fb5ea6dec

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit e21c164 into kubermatic:master Aug 15, 2022
@xrstf xrstf deleted the fix-gimps-download branch August 15, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@mfranczy mfranczy Awaiting requested review from mfranczy

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.21
Development

Successfully merging this pull request may close these issues.

gimps (hack/verify-import.sh): move to .zip and upgrade version
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik