Fix wrong quota filtering when preset.spec.cpu has no quantity

[hdurand0710]

Signed-off-by: Helene Durand helene@kubermatic.com

What this PR does / why we need it:
We were wrongly discarding some presets, like

apiVersion: kubevirt.io/v1
kind: VirtualMachineInstancePreset
metadata:
  name: dedicated-cpu
  namespace: default
spec:
  domain:
    ioThreadsPolicy: auto
    cpu:
      dedicatedCpuPlacement: true
      isolateEmulatorThread: true
    devices: {}
    resources:
      requests:
        cpu: 4
        memory: 16Gi
  selector:
    matchLabels:
      kubevirt.io/flavor: dedicated-cpu

with an error:
2022-09-23T08:24:16.810+0200 error provider/kubevirt.go:309 skipping VMIPreset:dedicated-cpu, fetching presetResourceDetails failed:should not specify both spec.domain.cpu and spec.domain.resources.[requests/limits].cpu in VMIPreset

Which issue(s) this PR fixes:

Fixes #11044

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix wrong quota filtering when VirtualMachineInstancePreset.spec.cpu has no quantity but only other fields.

Documentation:

NONE

[mfranczy]

/approve
/lgtm

[kubermatic-bot]

LGTM label has been added.

Git tree hash: 27c35df6f9d620cc9b8b8e14d00aa3da8a6c8398

[ahmedwaleedmalik]

/approve

[hdurand0710]

/test pre-kubermatic-e2e-kubevirt-centos-1.24
/test pre-kubermatic-e2e-kubevirt-ubuntu-1.24

[lsviben]

/approve

we should add this to the next patch release for 2.21

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710, lsviben, mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/handler/OWNERS [ahmedwaleedmalik,lsviben]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hdurand0710]

/cherrypick release/v2.21

[kubermatic-bot]

@hdurand0710: once the present PR merges, I will cherry-pick it on top of release/v2.21 in a new PR and assign it to you.

In response to this:

/cherrypick release/v2.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hdurand0710]

/retest

[kubermatic-triage-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[hdurand0710]

/retest

[kubermatic-bot]

@hdurand0710: new pull request created: #11056

In response to this:

/cherrypick release/v2.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.