New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix convert-kubeconfig command not generating a SA token #11197
fix convert-kubeconfig command not generating a SA token #11197
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 3222570ed0b32783745479528b424a53de12c24b
|
/retest |
/retest Prow, you home, go drunk! |
/cherrypick release/v2.21 |
/cherrypick release/v2.20 |
@xrstf: new pull request created: #11199 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xrstf: #11197 failed to apply on top of branch "release/v2.20":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xrstf I think this still needs a manual 2.20 cherry-pick. |
Does this need a 2.19 backport as well? |
What this PR does / why we need it:
This is a follow-up to #11190, applying the same simple fix to the
convert-kubeconfig
subcommand in the KKP installer./kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: