Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extended fields for credential presets #3723

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Jul 2, 2019

What this PR does / why we need it: extends credentials for extra parameters like network configuration

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3705

preset.yaml example:
presets:
  digitalocean:
    credentials:
      - name: digitalocean
        token:
  azure:
    credentials:
      - name: azure
        tenantId:
        subscriptionId:
        clientId:
        clientSecret:
        resourceGroup:
        vnet:
        subnet:
        routeTable:
        securityGroup:
  aws:
    credentials:
      - name: aws
        accessKeyId:
        secretAccessKey:
        vpcId:
        subnetId:
        routeTableId:
        instanceProfileName:
        securityGroupID:
  openstack:
    credentials:
      - name: openstack
        username:
        password:
        tenant:
        domain: DEFAULT
        network:
        securityGroups:
        floatingIpPool:
        routerID:
        subnetID:
  hetzner:
    credentials:
      - name: default
        token:
  vsphere:
    credentials:
      - name: default
        username:
        password:
        vmNetName:
  packet:
    credentials:
      - name: default
        apiKey:
        projectId:
        billingCycle:
  gcp:
    credentials:
      - name: default
        serviceAccount:
        network:
        subnetwork:

@zreigz zreigz requested a review from floreks July 2, 2019 12:07
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. team/ui size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2019
@floreks
Copy link
Contributor

floreks commented Jul 2, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50e24c95db34580ed0ca94022d0febbd76532a20

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

Associated issue: #3705

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@floreks
Copy link
Contributor

floreks commented Jul 2, 2019

/retest

1 similar comment
@zreigz
Copy link
Contributor Author

zreigz commented Jul 2, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit d091570 into master Jul 2, 2019
@kubermatic-bot kubermatic-bot deleted the extended-credentials branch July 2, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define default network for providers
3 participants