Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for audit logging inside user clusters #4151

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Add support for audit logging inside user clusters #4151

merged 1 commit into from
Aug 23, 2019

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented Aug 22, 2019 •
edited
Loading

What this PR does / why we need it:
Requirement for this issue.

Special notes for your reviewer:
None

Documentation:
No changes yet.

Does this PR introduce a user-facing change?:

Add support for kubernetes auditing

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. team/lifecycle size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 22, 2019
@eqrx eqrx force-pushed the auditing branch 3 times, most recently from 3560086 to 95c6c4e Compare August 22, 2019 15:09
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 22, 2019
@eqrx eqrx changed the title WIP: Add support for audit logging inside user clusters Add support for audit logging inside user clusters Aug 23, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2019
@eqrx eqrx force-pushed the auditing branch 7 times, most recently from 4372cab to d548637 Compare August 23, 2019 13:55
@mrIncompetent
Copy link
Contributor

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d4344413c4aa9b15bdd55327364269fe226c5ea

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrIncompetent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@kubermatic-bot kubermatic-bot merged commit 4992d44 into master Aug 23, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Aug 23, 2019
@kubermatic-bot kubermatic-bot deleted the auditing branch August 23, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrIncompetent mrIncompetent mrIncompetent left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eqrx @mrIncompetent @kubermatic-bot