Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alertmanager to 0.19 #4340

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Update Alertmanager to 0.19 #4340

merged 1 commit into from
Sep 25, 2019

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Sep 20, 2019

What this PR does / why we need it:
Nothing fancy to see here.

Does this PR introduce a user-facing change?:

update Alertmanager to 0.19

/hold until #4339 is merged so the version bumps work as expected

@xrstf xrstf requested a review from kron4eg September 20, 2019 13:05
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. team/seed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2019
@xrstf
Copy link
Contributor Author

xrstf commented Sep 20, 2019

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2019
@xrstf xrstf changed the title update Alertmanager to 0.19 Update Alertmanager to 0.19 Sep 20, 2019
kron4eg
kron4eg approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bd09444bf6617323435ab06ebefeb08841950569

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@xrstf
Copy link
Contributor Author

xrstf commented Sep 25, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
kron4eg
kron4eg approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54f7843f47b9abcdc8871728c0bb41db7932aa34

@kubermatic-bot kubermatic-bot merged commit fcbc504 into master Sep 25, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Sep 25, 2019
@kubermatic-bot kubermatic-bot deleted the alertmanager-0.19 branch September 25, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrstf @kubermatic-bot @kron4eg