Update nginx-ingress-controller to 0.26.1 #4400
Conversation
kubermatic-bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
| config: {} | ||
| extraArgs: | ||
| - '--default-ssl-certificate=default/kubermatic-tls-certificates' |
There was a problem hiding this comment.
What’s the reason behind this move? It used to be a strictly defined integration point between ingress controller and certmanager and now it became a possible to be overwritten and forgotten configuration option.
There was a problem hiding this comment.
It felt weird to read some Kubermatic identifier within the nginx template, and a good opportunity to add the extraArgs stuff. But I don't feel strongly about it.
There was a problem hiding this comment.
So.... keep it or remove it?
| version: 1.0.2 | ||
| appVersion: 0.25.1 | ||
| version: 1.0.3 | ||
| appVersion: 0.26.0 |
xrstf
changed the title
|
LGTM label has been added. Git tree hash: 4468468ce6c654a5fbe40990adf674466379728c
|
What this PR does / why we need it:
This has a fix for the issue plaguing our offline cluster. It was a smooth update on dev.
This PR also adds the
allowPrivilegeEscalationfield to the security context, which was set since 0.22 by kubernetes/ingress-nginx#3342 but we never noticed because we don't have policies forbidding this behaviour by default.The memory limit was increased because the release notes for 0.26 mentioned higher resource usage while connections are drained.
Does this PR introduce a user-facing change?: