Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack: continue when trying to add a security rule that already exists #4476

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

kdomanski
Copy link
Contributor

What this PR does / why we need it:
Prevents Security group rule already exists. Rule id is $UUID. error when resuming a failed security group creation attempt.

Openstack: Fixed a bug preventing an interrupted cluster creation from being resumed.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. team/lifecycle size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2019
@kdomanski
Copy link
Contributor Author

/assign @chrkl

@chrkl
Copy link

chrkl commented Oct 11, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 88f197ed0e12bbf883e32cfb600ba549c6e52942

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrkl, kdomanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kdomanski
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot merged commit e64a3ee into master Oct 11, 2019
@kubermatic-bot kubermatic-bot added this to the v2.12 milestone Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants