-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable update window #5318
Conversation
/assign @floreks |
please regenerate client |
This adds a configurable update window with a start time, (e.g. "02:00", or :"Thu 02:00") and length (e.g. "1h") to a cluster. It can be used to limit various update operations to a given time frame only. The first usage is to configure the CoreOS operator node reboot window, see https://github.com/coreos/container-linux-update-operator/blob/master/doc/reboot-windows.md. In chose to make it a generic setting since we are planning to use this in the future for other things, like automatic cluster upgrades or in the addon controller. Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
@zreigz done |
/lgtm |
LGTM label has been added. Git tree hash: 6935e06daa9d9c386644d1187b8e42c10bc88ec5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kdomanski, zreigz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history Silence the bot with an Also, here is a cat. |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v2.14 |
@kdomanski: new pull request created: #5365 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Copy of #4972 which doesn't work properly anymore since Bastian's fork is deleted.