Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable update window #5318

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Configurable update window #5318

merged 3 commits into from
Apr 21, 2020

Conversation

kdomanski
Copy link
Contributor

Copy of #4972 which doesn't work properly anymore since Bastian's fork is deleted.

Added configurable time window for coreos-operator node reboots

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 20, 2020
@kdomanski
Copy link
Contributor Author

/assign @floreks

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. team/lifecycle labels Apr 20, 2020
@zreigz
Copy link
Contributor

zreigz commented Apr 20, 2020

please regenerate client /hack/gen-api-client.sh

@zreigz zreigz self-assigned this Apr 20, 2020
bashofmann and others added 3 commits April 20, 2020 14:15
This adds a configurable update window with a start time, (e.g. "02:00", or :"Thu 02:00") and length (e.g. "1h") to a cluster.

It can be used to limit various update operations to a given time frame only.

The first usage is to configure the CoreOS operator node reboot window, see https://github.com/coreos/container-linux-update-operator/blob/master/doc/reboot-windows.md.

In chose to make it a generic setting since we are planning to use this in the future for other things, like automatic cluster upgrades or in the addon controller.

Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
@kdomanski
Copy link
Contributor Author

@zreigz done

@zreigz
Copy link
Contributor

zreigz commented Apr 21, 2020

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6935e06daa9d9c386644d1187b8e42c10bc88ec5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdomanski, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit a882ea9 into master Apr 21, 2020
@kubermatic-bot kubermatic-bot added this to the v2.13 milestone Apr 21, 2020
@kubermatic-bot kubermatic-bot deleted the timewindow branch April 21, 2020 17:20
@kdomanski
Copy link
Contributor Author

/cherry-pick release/v2.14

@kubermatic-bot
Copy link
Contributor

@kdomanski: new pull request created: #5365

In response to this:

/cherry-pick release/v2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants