Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow admin to create cluster #5373

Merged
merged 1 commit into from
May 7, 2020
Merged

allow admin to create cluster #5373

merged 1 commit into from
May 7, 2020

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented May 7, 2020

What this PR does / why we need it: allow admin to create cluster and node deployment

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5372

allow admin to create cluster and node deployment

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 7, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. team/ui labels May 7, 2020
@zreigz
Copy link
Contributor Author

zreigz commented May 7, 2020

/retest

1 similar comment
@zreigz
Copy link
Contributor Author

zreigz commented May 7, 2020

/retest

@zreigz zreigz requested a review from maciaszczykm May 7, 2020 08:44
@floreks
Copy link
Contributor

floreks commented May 7, 2020

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9f2feca346a03b105eec42effbac7fed523a2482

@kubermatic-bot kubermatic-bot merged commit 739d78d into kubermatic:master May 7, 2020
@maciaszczykm maciaszczykm deleted the allow-admin-clusters branch May 7, 2020 10:52
@kdomanski
Copy link
Contributor

/cherry-pick release/v2.14

@kubermatic-bot kubermatic-bot mentioned this pull request May 11, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@kdomanski: new pull request created: #5395

In response to this:

/cherry-pick release/v2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow admin to create cluster and node deployment for any project
4 participants
@zreigz @kubermatic-bot @floreks @kdomanski