Remove default credentials from Helm charts #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note-action-required
xrstf
commented
Jun 9, 2020
Comment on lines
+2
to
+3
| admin_password = {{ .Values.grafana.password | quote }} | ||
| admin_user = {{ .Values.grafana.user | quote }} |
There was a problem hiding this comment.
There was zero good reason to base64 something that is clearly labelled as "PASSWORD". Obscurity is one thing, but obscurity plus exhibition is a weird combo.
This PR is the perfect opportunity to remove this needless extra step when setting up Kubermatic.
|
/lgtm |
|
LGTM label has been added. Git tree hash: bca6a12d7c1415c8206e81199b95cce43e7a1146
|
xrstf
force-pushed
the
remove-default-credentials
branch
from
53857ee
to
892451c
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: ef6bf5663530508cb59fc49d424ccd31e146ec65
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kdomanski, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prevent accidentally insecure configurations by removing the default credentials. This gets even more important once Kubermatic is OSS. Unfortunately this requires existing installations to be manually migrated.
Documentation:
kubermatic/docs#331
Does this PR introduce a user-facing change?: