Shrink down Docker image size #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/test pre-kubermatic-e2e-aws-coreos-1.16 |
kron4eg
approved these changes
Jul 3, 2020
|
LGTM label has been added. Git tree hash: 78d223c9228d1449d8aae6b063343c7d9c4ce50d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We should not publish helper tools in our official Docker images. It makes them seem to be officially supported tools. Likewise, removing a few binaries from the Docker image shrunk it down from 850 to 600 MiB on my machine. Quite a bit!
The change to the Makefile snuck in because just typing
makebreaks as theci-lint.shcannot handle the variable not being defined. Exporting it from the Makefile is the easiest workaorund.Does this PR introduce a user-facing change?: