-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Seed.Spec.NodeportProxy.Annotation syncing to created servi… #5730
implement Seed.Spec.NodeportProxy.Annotation syncing to created servi… #5730
Conversation
…ce in seed-controller Signed-off-by: erdii <erdiicodes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things
Signed-off-by: erdii <me@erdii.engineering>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 88c95bef93b09c99e545998dc273acfa22ab4228
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erdii, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xrstf I added (or removed? 😛) the requested changes |
/retest |
2 similar comments
/retest |
/retest |
…ce in seed-controller
What this PR does / why we need it: title
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #Special notes for your reviewer: This is propably not complete since I'm still very newbie-ish with golang. Please point out incorrect or missing stuff and I'll happily fix/add it.
Documentation:
Does this PR introduce a user-facing change?: