Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperkube image replaced with k8s.gcr.io respective images #5758

Merged
merged 5 commits into from
Aug 26, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Aug 13, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xRef #5717

Special notes for your reviewer:
OpenShift usage of hypekube will be in separate PR

Documentation:

Does this PR introduce a user-facing change?:

Hyperkube image replaced with k8s.gcr.io respective images

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2020
@kron4eg kron4eg force-pushed the hyperkube-replacement branch 2 times, most recently from 435315a to 8207d6e Compare August 14, 2020 08:28
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments regarding follow-up tasks.

/lgtm
/hold
if anyone else wants to take a look, otherwise remove

addons/kube-proxy/daemonset.yaml Show resolved Hide resolved
pkg/resources/machinecontroller/deployment.go Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@xmudrii
Copy link
Member

xmudrii commented Aug 14, 2020

Looks like tests are failing
/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2020
@kron4eg kron4eg force-pushed the hyperkube-replacement branch 2 times, most recently from dc725ed to 4393b7b Compare August 20, 2020 15:13
@kron4eg
Copy link
Member Author

kron4eg commented Aug 20, 2020

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Aug 20, 2020

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Aug 20, 2020

/test pre-kubermatic-e2e-aws-flatcar-1.18

@kron4eg
Copy link
Member Author

kron4eg commented Aug 21, 2020

/retest

@kron4eg kron4eg force-pushed the hyperkube-replacement branch 4 times, most recently from c13e643 to 084ae38 Compare August 24, 2020 13:24
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Aug 24, 2020

/retest

Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
into apiserver, schedules and controllermanager

Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Aug 26, 2020

rebased.
@xmudrii PTAL

@xmudrii
Copy link
Member

xmudrii commented Aug 26, 2020

/retest

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f16d2870e9e549773d2854d4096eee431c51625e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Aug 26, 2020

/hold cancel
:shipit:

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@kubermatic-bot kubermatic-bot merged commit 9699770 into master Aug 26, 2020
@kubermatic-bot kubermatic-bot added this to the v2.15 milestone Aug 26, 2020
@kubermatic-bot kubermatic-bot deleted the hyperkube-replacement branch August 26, 2020 15:14
phiphi282 pushed a commit to phiphi282/kubermatic that referenced this pull request Oct 19, 2020
…c#5758)

* Replace hyperkube with k8s.gcr.io images

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Update fixtures

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* kube-proxy from k8s.gcr.io

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Host mount ca-certs

into apiserver, schedules and controllermanager

Signed-off-by: Artiom Diomin <kron82@gmail.com>

* Update fixtures

Signed-off-by: Artiom Diomin <kron82@gmail.com>
phiphi282 added a commit to phiphi282/kubermatic that referenced this pull request Oct 19, 2020
K8s-4672 Hyperkube image replaced with k8s.gcr.io respective images (cherry-picked kubermatic#5758)

See merge request kubernetes/kubermatic!81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants